New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JoinedFastqManifestPhred33 as a format for joined reads #162

Open
gregcaporaso opened this Issue Nov 30, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@gregcaporaso
Copy link
Member

gregcaporaso commented Nov 30, 2017

No description provided.

@ebolyen

This comment has been minimized.

Copy link
Member

ebolyen commented Nov 30, 2017

This seems like it kind of counteracts the distinction between semantic type and format, since there isn't really a difference here between single and joined from a data-structure perspective.

In my mind we would want to share the formats between SingleEnd and JoinedEnd as it means less code, testing, and transformers.

Granted the current naming is probably confusing.

@gregcaporaso

This comment has been minimized.

Copy link
Member

gregcaporaso commented Dec 1, 2017

@ebolyen, that makes sense. It's really just the confusing naming that I'm trying to get around so I'm open to solutions that would help with that.

@thermokarst

This comment has been minimized.

Copy link
Member

thermokarst commented Dec 1, 2017

What about SingleOrJoinedFastqManifestPhred33 (coupled with deprecating SingleEnd...)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment