Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Move partitioning and collating actions from q2-moshpit to q2-types #332

Closed
VinzentRisch opened this issue May 24, 2024 · 0 comments · Fixed by #334
Closed

MAINT: Move partitioning and collating actions from q2-moshpit to q2-types #332

VinzentRisch opened this issue May 24, 2024 · 0 comments · Fixed by #334

Comments

@VinzentRisch
Copy link
Contributor

VinzentRisch commented May 24, 2024

Improvement Description
Partitioning and collating actions for various formats are currently located in q2-moshpit. Other plugins (eg. q2-amr) need these functions, what introduces q2-moshpit as a dependency what can lead to issues.
As the formats are defined in q2-types, it makes sense to move the actions also to q2-types.

All the code for partitioning/collating actions has to be moved to q2-types. This will require adjusting all the actions which use the actions being moved.

See here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants