Initial implementation of DRCOV-compatible code coverage collection.

[assafcarlsbad]

• The output file can be loaded by an IDA plugin such as Lighthouse in order to visualize the collected code coverage.
  
• For this revision, only the UEFI loader was modified to keep a list of loaded images. I believe this amendment can be ported to the other loaders with relative ease.

[xwings]

Hi,

Add your name into credits.txt too.

[assafcarlsbad]

Already did 😄

[xwings]

yo,

I just woke up and on my mobile. So i did not realize it,

Btw, qiling/coverage.py need to be somewhere. It should not be in qiling. This is a feature not widely use in the core engine.

[aquynh]

Please put more docs in coverage.py and qltool that this is DRCOV format, from DynamoRio

Also, making it easy to extend for other coverage formats in the future will be nice.

[assafcarlsbad]

Hi, I made some changes in accordance with your comments. Can you please re-review?

[aquynh]

Nice work!

Does qltool report error if i pass in an invalid coverage name?

[aquynh]

Please update README with a new example.

[assafcarlsbad]

@aquynh

Nice work!

Does qltool report error if i pass in an invalid coverage name?

carlsbad@AssafC-T490:/mnt/c/Users/carlsbad/Code/qiling$ ./qltool run --rootfs . --debug --coverage-format foo -c new_tcg_dxe.cov /mnt/c/Users/carlsbad/Code/UEFI_RETool/modules/TcgDxe /mnt/c/Users/carlsbad/Code/UEFI_RETool/modules/TcgPlatformSetupPolicy
usage: qltool run [-h] [-f FILE] --rootfs ROOTFS [--args ...] [-o OUTPUT] [-v VERBOSE] [--env FILE] [-g GDB] [--profile PROFILE]
                  [--strace] [--dump] [--debug] [--disasm] [--console CONSOLE] [-e FUNCTION NAME] [--log-dir DIRECTORY NAME]
                  [--trace] [--root] [--debug_stop] [-m] [--timeout TIMEOUT] [-c COVERAGE_FILE] [--coverage-format {drcov}]
                  ...
qltool run: error: argument --coverage-format: invalid choice: 'foo' (choose from 'drcov')

Please update README with a new example.

Done :)

[xwings]

is should be ,./qltool run -f examples/rootfs/xxxx

[assafcarlsbad]

Fixed.

[jershmagersh]

Great work, I was thinking of implementing the same thing, but you've done a much better job. This should also work with something like Dragon Dance: https://github.com/0ffffffffh/dragondance

[aquynh]

A final request from me: please have a README in coverage/ about this coverage framework, with some intructions on how to extend it for a new coverage.

[xwings]

A final request from me: please have a README in coverage/ about this coverage framework, with some intructions on how to extend it for a new coverage

the readme should goes to docs, maybe a differents pr in https://github.com/qilingframework/rtfd.io

[aquynh]

it is good to have that in source code, too.

[assafcarlsbad]

Done. Please let me know if I'm missing something or if you want me to elaborate more on some aspects.

[xwings]

perfect !

thanks !