Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Refactor task type system #151

Merged
merged 21 commits into from Nov 4, 2019

Conversation

@Xuanwo
Copy link
Collaborator

Xuanwo commented Nov 1, 2019

No description provided.

Xuanwo added 8 commits Nov 1, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #151 into master will decrease coverage by 16.4%.
The diff coverage is 1.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #151       +/-   ##
===========================================
- Coverage   28.98%   12.57%   -16.41%     
===========================================
  Files          16       16               
  Lines         942     1392      +450     
===========================================
- Hits          273      175       -98     
- Misses        658     1209      +551     
+ Partials       11        8        -3
Impacted Files Coverage Δ
task/generated.go 6.51% <ø> (-23.04%) ⬇️
task/segment.go 0% <ø> (ø) ⬆️
task/list.go 0% <0%> (ø) ⬆️
task/copy.go 0% <0%> (-25.54%) ⬇️
task/iterate.go 0% <0%> (ø) ⬆️
task/delete.go 0% <0%> (ø) ⬆️
utils/task.go 34.5% <25%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd0d906...0870794. Read the comment docs.

Xuanwo added 4 commits Nov 2, 2019
@Xuanwo Xuanwo mentioned this pull request Nov 2, 2019
Xuanwo and others added 7 commits Nov 2, 2019
@Prnyself Prnyself force-pushed the feature/task_value_system branch from 827c4ea to 0870794 Nov 4, 2019
@Xuanwo Xuanwo merged commit 968a55a into master Nov 4, 2019
3 of 5 checks passed
3 of 5 checks passed
codecov/patch 1.73% of diff hit (target 28.98%)
Details
codecov/project 12.57% (-16.41%) compared to fd0d906
Details
GolangCI No issues found!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Xuanwo Xuanwo deleted the feature/task_value_system branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.