Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass user specified directories to the build system #17

Closed
nonhermitian opened this issue Jan 2, 2019 · 4 comments
Closed

Pass user specified directories to the build system #17

nonhermitian opened this issue Jan 2, 2019 · 4 comments
Labels
build system enhancement New feature or request

Comments

@nonhermitian
Copy link
Contributor

Informations

  • Qiskit AER version: 0.1
  • Operating system: OSX

What is the current behavior?

The make system does not find the OpenBLAS libraries in their default location in OSX. Instead, the Apple Accelerate libs are always used.

Steps to reproduce the problem

What is the expected behavior?

The installer should find the OpenBLAS libs if they are installed in the default dirs.

Suggested solutions

@atilag atilag added the good first issue Good for newcomers label Jan 8, 2019
@atilag
Copy link
Member

atilag commented Jan 8, 2019

There's a way to specify the BLAS implementation you want to use for building in CMake. Apple Accelerate is our first candidate, so if CMake finds it, it just uses it.
This is not configurable at the moment.
Seems to be a good candidate for a Good First Issue

@atilag
Copy link
Member

atilag commented Apr 3, 2019

Adding HINTS parameter to the find_package() and takeing it's value from a env variable seems the way to go here:

find_package(BLAS HINTS "$ENV{MY_ENV_VARIABLE}" REQUIRED)

@atilag atilag changed the title make cannot find OpenBLAS lib on OSX Pass user specified directories to the build system Apr 3, 2019
@a07r
Copy link

a07r commented Sep 21, 2019

@atilag

I'm looking to get started, Not sure what "build system" tag is for! (there isn't a description to it in the labels)

Can I start here with this issue? (It's an old issue, has anything changed since you last made the comment!)

Edit: My Bad! I didn't notice that it's assigned to you already, Please ignore this comment!

@atilag atilag added enhancement New feature or request and removed good first issue Good for newcomers labels Oct 28, 2019
@chriseclectic chriseclectic mentioned this issue Jan 9, 2020
13 tasks
@atilag atilag removed their assignment Jan 14, 2020
@atilag
Copy link
Member

atilag commented Feb 7, 2020

We have introduced a way to do this with BLAS so I'm closing this issue.

@atilag atilag closed this as completed Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants