From 520ee5c6acf2883836bcb8fa8bbb63ce5e4b41b6 Mon Sep 17 00:00:00 2001 From: arunkumar-narasimhan <124154466+arunkumar-narasimhan@users.noreply.github.com> Date: Mon, 22 May 2023 17:21:50 +0530 Subject: [PATCH] unify spelling of controllers unify spelling of controllers by omitting dash in description and documentation --- Modelica/Blocks/Continuous.mo | 14 +++++++------- .../Examples/Systems/ControlledMixingUnit.mo | 2 +- .../ControlledDCDrives/Utilities/LimitedPI.mo | 4 ++-- .../Machines/Utilities/DQCurrentController.mo | 2 +- .../Systems/RobotR3/Utilities/Controller.mo | 4 ++-- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/Modelica/Blocks/Continuous.mo b/Modelica/Blocks/Continuous.mo index 1eba8933f6..7811e0c14a 100644 --- a/Modelica/Blocks/Continuous.mo +++ b/Modelica/Blocks/Continuous.mo @@ -598,7 +598,7 @@ This is discussed in the description of package textString="T=%T")})); end PI; - block PID "PID-controller in additive description form" + block PID "PID controller in additive description form" import Modelica.Blocks.Types.Init; extends Interfaces.SISO; @@ -689,8 +689,8 @@ This is discussed in the description of package textString="Ti=%Ti")}), Documentation(info="

-This is the text-book version of a PID-controller. -For a more practically useful PID-controller, use +This is the text-book version of a PID controller. +For a more practically useful PID controller, use block LimPID.

@@ -1011,18 +1011,18 @@ together) and using the following strategy:
  1. Set very large limits, e.g., yMax = Modelica.Constants.inf
    2. -
  2. Select a P-controller and manually enlarge parameter k +
  3. Select a P controller and manually enlarge parameter k (the total gain of the controller) until the closed-loop response cannot be improved any more.
    4. -
  4. Select a PI-controller and manually adjust parameters +
  5. Select a PI controller and manually adjust parameters k and Ti (the time constant of the integrator). The first value of Ti can be selected, such that it is in the order of the time constant of the oscillations occurring with - the P-controller. If, e.g., vibrations in the order of T=10 ms + the P controller. If, e.g., vibrations in the order of T=10 ms occur in the previous step, start with Ti=0.01 s.
  6. If you want to make the reaction of the control loop faster (but probably less robust against disturbances and measurement noise) - select a PID-Controller and manually adjust parameters + select a PID Controller and manually adjust parameters k, Ti, Td (time constant of derivative block).
  7. Set the limits yMax and yMin according to your specification.
  8. Perform simulations such that the output of the PID controller diff --git a/Modelica/Clocked/Examples/Systems/ControlledMixingUnit.mo b/Modelica/Clocked/Examples/Systems/ControlledMixingUnit.mo index 986f431a2f..db9bfde849 100644 --- a/Modelica/Clocked/Examples/Systems/ControlledMixingUnit.mo +++ b/Modelica/Clocked/Examples/Systems/ControlledMixingUnit.mo @@ -249,7 +249,7 @@ as desired cooling temperature at the output of the controller) and the desired temperature T (which is used as desired value for the feedback controller). This part of the control system is the \"feed-forward\" part that computes the desired actuator signal. -As feedback controller a simple P-Controller with one gain is used. +As feedback controller a simple P Controller with one gain is used.

    diff --git a/Modelica/Electrical/Machines/Examples/ControlledDCDrives/Utilities/LimitedPI.mo b/Modelica/Electrical/Machines/Examples/ControlledDCDrives/Utilities/LimitedPI.mo index 7ec091a8a0..a5b1911d2f 100644 --- a/Modelica/Electrical/Machines/Examples/ControlledDCDrives/Utilities/LimitedPI.mo +++ b/Modelica/Electrical/Machines/Examples/ControlledDCDrives/Utilities/LimitedPI.mo @@ -1,6 +1,6 @@ within Modelica.Electrical.Machines.Examples.ControlledDCDrives.Utilities; block LimitedPI - "Limited PI-controller with anti-windup and feed-forward" + "Limited PI controller with anti-windup and feed-forward" extends Modelica.Blocks.Interfaces.SISO; import Modelica.Blocks.Types.Init; import Modelica.Constants.inf; @@ -196,7 +196,7 @@ equation Proportional - Integral - controller with optional feed-forward and limitation at the output.

    -The integral part can be switched off to obtain a limited P-controller. +The integral part can be switched off to obtain a limited P controller.

    The feed-forward gain can either be constant or given by the optional input kFF. diff --git a/Modelica/Electrical/Machines/Utilities/DQCurrentController.mo b/Modelica/Electrical/Machines/Utilities/DQCurrentController.mo index d47eac127e..c4a2dd0d6a 100644 --- a/Modelica/Electrical/Machines/Utilities/DQCurrentController.mo +++ b/Modelica/Electrical/Machines/Utilities/DQCurrentController.mo @@ -117,7 +117,7 @@ Simple Current controller

    The desired d- and q-component of the space phasor current in rotor fixed coordinate system are given by inputs id and iq. Using the given rotor position (input phi), the actual three-phase currents are measured and transformed to the d-q coordinate system. -Two PI-controllers determine the necessary d- and q- voltages, which are transformed back to three-phase (output y[3]). +Two PI controllers determine the necessary d- and q- voltages, which are transformed back to three-phase (output y[3]). They can be used to feed a voltage source which in turn feeds a permanent magnet synchronous machine.

    diff --git a/Modelica/Mechanics/MultiBody/Examples/Systems/RobotR3/Utilities/Controller.mo b/Modelica/Mechanics/MultiBody/Examples/Systems/RobotR3/Utilities/Controller.mo index 7825416185..07e0802258 100644 --- a/Modelica/Mechanics/MultiBody/Examples/Systems/RobotR3/Utilities/Controller.mo +++ b/Modelica/Mechanics/MultiBody/Examples/Systems/RobotR3/Utilities/Controller.mo @@ -87,8 +87,8 @@ equation lineColor={0,0,127})}), Documentation(info="

    -This controller has an inner PI-controller to control the motor speed, -and an outer P-controller to control the motor position of one axis. +This controller has an inner PI controller to control the motor speed, +and an outer P controller to control the motor position of one axis. The reference signals are with respect to the gear-output, and the gear ratio is used in the controller to determine the motor reference signals. All signals are communicated via the