New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low-hanging performance improvements #79

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
2 participants
@peol
Member

peol commented Nov 5, 2018

No description provided.

@netlify

This comment has been minimized.

netlify bot commented Nov 5, 2018

Deploy preview for catwalk ready!

Built with commit 19ce7f8

https://deploy-preview-79--catwalk.netlify.com

@peol peol requested review from hrigner and snurrfint and removed request for hrigner Nov 5, 2018

@peol

This comment has been minimized.

Member

peol commented Nov 5, 2018

This was measured with the Lighthouse extension.

Before:

screen shot 2018-11-05 at 17 28 56

After (SEO is 100%, netlify sets a header on CI builds causing it to go lower):

screen shot 2018-11-05 at 17 28 25

@hrigner

hrigner approved these changes Nov 5, 2018

Nice! :)

@hrigner

This comment has been minimized.

Member

hrigner commented Nov 5, 2018

The 'x' might be a bit small.. and italic 😱

@hrigner

This comment has been minimized.

Member

hrigner commented Nov 5, 2018

screen shot 2018-11-05 at 18 48 20

@peol

This comment has been minimized.

Member

peol commented Nov 5, 2018

I fix! I'll rebase your PR into this one first :)

@peol

This comment has been minimized.

Member

peol commented Nov 6, 2018

Material icons are removed in this PR, see below for the replacement and let me know if I should explore other "X":s.
screen shot 2018-11-06 at 09 42 00

@peol peol merged commit d1dfcdd into master Nov 6, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
cla/verification CLA OK
deploy/netlify Deploy preview ready!
Details

@peol peol deleted the lighthouse branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment