New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #12

Merged
merged 5 commits into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@peol
Member

peol commented Nov 7, 2018

  • Fixed: Rendering while database was empty
  • Fixed: Scanning users and manual input
  • Added: Form for manual player input
  • Added: User email and contact consent
  • Added: Error boundary/screen when exceptions are thrown
  • Fixed: chart rendering outside of container
  • Fixed: sensor data streaming
  • Fixed: UI rendering too fast causing socket-not-open-yet errors

peol added some commits Nov 7, 2018

Some bugfixes:
* Rendering while database was empty
* Scan users
* Fix CSS layout
* Fix scanning users and manual input
* Fix adding and changing user info
* Fix chart rendering outside of container

@peol peol requested a review from JohanBjerning Nov 7, 2018

@JohanBjerning

LGTM, only problem so far was when selecting a user that didn't have contact and email in the database. But only a problem when you already have users in the database so not critical.

export default function useFormValue(initialValue) {
const [val, setVal] = useState(initialValue);
return [val, (data) => {
if (data.target) {

This comment has been minimized.

@JohanBjerning

JohanBjerning Nov 7, 2018

Contributor

Old entries in the database will lack the contact, so will crash, so maybe also check data && data.target?

@peol

This comment has been minimized.

Member

peol commented Nov 7, 2018

Good catch, I'll add a new migration in the migrate-db.js script and you can run that to get compatible.

@peol

This comment has been minimized.

Member

peol commented Nov 7, 2018

Run node server/db/migrations/email-contact.js to fix old databases.

@peol peol merged commit 77b8779 into master Nov 7, 2018

1 check passed

cla/verification CLA OK

@peol peol deleted the bugfixes branch Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment