New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation regarding customization of driver #77

Merged
merged 4 commits into from Dec 6, 2018

Conversation

Projects
None yet
2 participants
@wennmo
Member

wennmo commented Dec 6, 2018

This closes #76

wennmo added some commits Dec 6, 2018

@peol

peol approved these changes Dec 6, 2018

```
COPY AthenaJDBC42_2.0.5.jar /usr/src/app
```bash
RUN mvn install:install-file -Dfile=/usr/src/app/AthenaJDBC42_2.0.5.jar -DgroupId=com.amazonaws.athena.jdbc -DartifactId=jdbcdriver -Dversion=2.0.5 -Dpackaging=jar

This comment has been minimized.

@peol

peol Dec 6, 2018

Member

Not sure how this works, you'd have to put the downloaded Jar file into the src/ folder? Perhaps clarify that in the instructions above?

This comment has been minimized.

@wennmo

wennmo Dec 6, 2018

Member

It didn't :)
We still need to copy the driver in the Dockerfile. I have updated the PR.

@wennmo wennmo merged commit 9c55db5 into master Dec 6, 2018

3 checks passed

ci/circleci: integration-test Your tests passed on CircleCI!
Details
ci/circleci: unit-test Your tests passed on CircleCI!
Details
cla/verification CLA OK

@wennmo wennmo deleted the doc branch Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment