New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump build image #265

Merged
merged 2 commits into from Oct 6, 2017

Conversation

Projects
None yet
3 participants
@peol
Member

peol commented Oct 5, 2017

Should fix the cache restoration issue in CCI.

Before:
screen shot 2017-10-05 at 16 19 07

After (cache key same before and after npm install):
screen shot 2017-10-05 at 16 18 56

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 5, 2017

Coverage Status

Coverage remained the same at 94.185% when pulling 0010ac4 on bump-build-image into f24a285 on master.

coveralls commented Oct 5, 2017

Coverage Status

Coverage remained the same at 94.185% when pulling 0010ac4 on bump-build-image into f24a285 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 5, 2017

Coverage Status

Coverage remained the same at 94.185% when pulling 45f1255 on bump-build-image into f24a285 on master.

coveralls commented Oct 5, 2017

Coverage Status

Coverage remained the same at 94.185% when pulling 45f1255 on bump-build-image into f24a285 on master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 5, 2017

Coverage Status

Coverage remained the same at 94.185% when pulling 45f1255 on bump-build-image into f24a285 on master.

coveralls commented Oct 5, 2017

Coverage Status

Coverage remained the same at 94.185% when pulling 45f1255 on bump-build-image into f24a285 on master.

@peol

This comment has been minimized.

Show comment
Hide comment
@peol

peol Oct 5, 2017

Member

(Reconfigured coveralls to not leave PR comments after getting spammed here)

Member

peol commented Oct 5, 2017

(Reconfigured coveralls to not leave PR comments after getting spammed here)

@peol peol requested a review from marcusoffesson Oct 6, 2017

@peol peol merged commit 92a96dd into master Oct 6, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
ci/integration Integration tests ran successfully!
coverage/coveralls Coverage remained the same at 94.185%
Details

@peol peol deleted the bump-build-image branch Oct 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment