New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on requestId #524

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
4 participants
@peol
Member

peol commented Oct 7, 2018

Fixes #413

@peol peol requested review from wennmo and hrigner Oct 7, 2018

@hrigner

This comment has been minimized.

Show comment
Hide comment
@hrigner

hrigner Oct 8, 2018

Member

Should this be included in the api spec?

Member

hrigner commented Oct 8, 2018

Should this be included in the api spec?

@wennmo

This comment has been minimized.

Show comment
Hide comment
@wennmo

wennmo Oct 8, 2018

Member

Yes, this should be added to the api specification as well.

Member

wennmo commented Oct 8, 2018

Yes, this should be added to the api specification as well.

@peol peol requested a review from miralemd Oct 8, 2018

@peol

This comment has been minimized.

Show comment
Hide comment
@peol

peol Oct 8, 2018

Member

@hrigner @wennmo Please re-review. I've added JSDoc for it but it's quite tricky since it's basically only accessible through a generated API which wasn't previously documented either. I've added @miralemd for sanity check as well.

Member

peol commented Oct 8, 2018

@hrigner @wennmo Please re-review. I've added JSDoc for it but it's quite tricky since it's basically only accessible through a generated API which wasn't previously documented either. I've added @miralemd for sanity check as well.

Show outdated Hide outdated src/schema.js Outdated
@wennmo

wennmo approved these changes Oct 10, 2018

LGTM

@peol peol merged commit 6eeb25f into master Oct 11, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
cla/verification CLA OK
coverage/coveralls Coverage remained the same at 94.051%
Details

@peol peol deleted the cancel-req branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment