Skip to content

Allow post_config.h to be implemented in userspace #11519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2021
Merged

Allow post_config.h to be implemented in userspace #11519

merged 1 commit into from
Jan 29, 2021

Conversation

spidey3
Copy link
Contributor

@spidey3 spidey3 commented Jan 11, 2021

Description

Allow post_config.h to be defined in userspace directories.

At present, we pay attention to it in keyboard and keymap directories, but not in the userspace.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jan 11, 2021
@spidey3
Copy link
Contributor Author

spidey3 commented Jan 12, 2021

@skullydazed this is the item we were discussing at https://discord.com/channels/440868230475677696/440868230475677698/798321601858764830

@drashna drashna requested a review from a team January 12, 2021 21:07
fauxpark
fauxpark approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#pragma weak

@tzarc
Copy link
Member

tzarc commented Jan 27, 2021

Conceptual approval, needs some conflict resolution, though.

@spidey3 spidey3 force-pushed the userspace_post_config branch from 6db2808 to 396f244 Compare January 29, 2021 00:02
@spidey3
Copy link
Contributor Author

spidey3 commented Jan 29, 2021

Conceptual approval, needs some conflict resolution, though.

Rebased and pushed.

@spidey3 spidey3 requested a review from tzarc January 29, 2021 00:04
@tzarc tzarc merged commit f59cd67 into qmk:develop Jan 29, 2021
@spidey3 spidey3 deleted the userspace_post_config branch January 29, 2021 00:06
@tzarc
Copy link
Member

tzarc commented Jan 29, 2021

Rebased and pushed.

Squashed and merged.

:)

BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@spidey3
Allow post_config.h to be implemented in userspace (qmk#11519)
9a5f259 
> Rebased and pushed.

Squashed and merged.

:)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc Awaiting requested review from tzarc

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spidey3 @tzarc @drashna @fauxpark