Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove QMK_KEYBOARD_CONFIG_H #11576

Merged
merged 1 commit into from Jan 22, 2021
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 16, 2021

Description

Given that all config.h files are automatically injected as part of the build process, this PR removes QMK_KEYBOARD_CONFIG_H which only functions some of the time.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team January 16, 2021 19:58
@skullydazed
Copy link
Member

Should probably leave this open a bit to give the involved people a heads up.

Pinging @losinggeneration @333fred @mtdjr @nooges @christopherjanzen @Talljoe @unxmaal @algernon @berfarah @issmirnov @jackhumbert @kejadlen @Townk

Copy link
Contributor

@losinggeneration losinggeneration left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like my contra layout build has been long broken (bisect says since 4e9fb1d). I'll fix that at a later time. I don't see any issue with the nyquist or levinson builds and don't think the contra layout issue should hold up this PR.

@zvecr zvecr merged commit a07c2a1 into qmk:develop Jan 22, 2021
@noroadsleft
Copy link
Member

Looks like my contra layout build has been long broken (bisect says since 4e9fb1d). I'll fix that at a later time. I don't see any issue with the nyquist or levinson builds and don't think the contra layout issue should hold up this PR.

@losinggeneration At a glance, it looks like your CATMAP macro maps to LAYOUT through your userspace, but I deleted the LAYOUT macro alias in the commit you flagged. If you map it to LAYOUT_ortho_4x12 for the Contra I'm guessing it will work again, but I have no idea what other boards you have running that code. We didn't have the Breaking Changes policy at that time, or the policy to tag users on GitHub when you edit their code (and I was even worse at C then than I am now).

Sorry for the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants