Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user keymaps that aren't compiling #11584

Merged
merged 16 commits into from Jan 30, 2021
Merged

Fix user keymaps that aren't compiling #11584

merged 16 commits into from Jan 30, 2021

Conversation

skullydazed
Copy link
Member

Description

A number of user keymaps don't compile. I've been compiling all:all a lot lately so having these cleaned up will help me a lot.

Types of Changes

  • Bugfix
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed
fix atomic:pvc so it compiles
8e24e6a
@skullydazed
enable LTO on atreus:ibnuda to bring it below the threshold
c68dc05
@skullydazed
enable bluetooth on atreus:clash to fix compile error
0027004
@skullydazed
fix chimera_ortho:gordon so it compiles
ab5791b
@skullydazed
fix clueboard/66:magicmonty to bring hue under the 255 limit
e99d4ea
@skullydazed
make the tetris keymap fit
9dd7c55
@skullydazed
add missing ADJUST key
e23d687
@skullydazed
remove conflicting NKRO_ENABLE flag
efee4ee
@skullydazed
strip fn_actions
63b0d89
@skullydazed
bring the xyverz keymap inline with LAYOUT_66_ansi
d64a674
@skullydazed
bring the bocaj keymap inline with LAYOUT_ortho_4x12
e421eb5
@skullydazed
change LAYOUT_planck_grid to LAYOUT_ortho_4x12
7db2c7b
@skullydazed
check for BACKLIGHT_ENABLE so this works on all keyboards
ffa26d8
@skullydazed
add missing _MACRO to users/brandonschlack/brandonschlack.h
213b04c
@skullydazed
rename callum's custom keycode that conflicts with a LUFA define
659b2df
@skullydazed
undef TAPPING_TERM in users/hvp/hvp.h
1724f88
@skullydazed skullydazed requested a review from a team January 17, 2021 02:46
@skullydazed skullydazed changed the title Fix user keymaps that aren't currently compiling Fix user keymaps that aren't compiling Jan 17, 2021
@skullydazed
Copy link
Member Author

Pinging @ClashTheBunny @DanielGGordon @magicmonty @martinmksiu @narze @unxmaal @Xyverz @JacobJerrell @jackhumbert @JunoNgx @brandonschlack @callum-oakley @hvpkod

If your name is above you have one or more files that will be changed by this PR. Please review and let me know if you have any concerns or would rather handle these updates yourself.

@JunoNgx
Copy link
Contributor

JunoNgx commented Jan 17, 2021 •
edited

@skullydazed I'm cool with the change on my keymap. Thank you very much.

callum-oakley
callum-oakley approved these changes Jan 17, 2021
View reviewed changes
Copy link
Contributor

@callum-oakley callum-oakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me!

@martinmksiu
Copy link
Contributor

yep happy with it

@brandonschlack
Copy link
Contributor

Good with me!

magicmonty
magicmonty approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@magicmonty magicmonty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with it. Thanks

@JacobJerrell
Copy link
Contributor

Reviewed my files, thanks! Sorry for any mistakes I made/introduced

@skullydazed skullydazed merged commit 051c077 into develop Jan 30, 2021
@skullydazed skullydazed deleted the fix_user_keymaps branch January 30, 2021 21:11
@narze
Copy link
Contributor

narze commented Feb 1, 2021

Looks like I'm late, but will send you fixes if found :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unxmaal unxmaal unxmaal left review comments

@fauxpark fauxpark fauxpark left review comments

@ClashTheBunny ClashTheBunny ClashTheBunny approved these changes

@magicmonty magicmonty magicmonty approved these changes

@drashna drashna drashna approved these changes

@brandonschlack brandonschlack brandonschlack approved these changes

@callum-oakley callum-oakley callum-oakley approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet