Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FAUXCLICKY feature (depricated) #11829

Merged
merged 4 commits into from Feb 9, 2021
Merged

Remove FAUXCLICKY feature (depricated) #11829

merged 4 commits into from Feb 9, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Feb 8, 2021

Only 2 boards were using it in the repo, actually. And audio clicky works better, as it supports any board that is supported by the audio feature, rather than just AVR and pin C6.

Types of Changes

  • Core

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Remove FAUXCLICKY feature (depricated)
425c55b 
only 2 boards were using it in the repo, actually. And audio clicky works better (supports more than just C6).
@drashna drashna requested a review from a team February 8, 2021 17:12
fauxpark
fauxpark approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍
Those empty lines can be removed from the rules.mks though too.

@drashna
Copy link
Member Author

drashna commented Feb 8, 2021

Fixed. A few cases are not, but that's to separate the LAYOUTS macro, to keep consistent with the rest of the repo.

@drashna drashna requested a review from a team February 8, 2021 20:55
@spidey3
Copy link
Contributor

spidey3 commented Feb 8, 2021

keyboards/handwired/promethium/keymaps/default/keymap.c and keyboards/handwired/promethium/keymaps/priyadi/keymap.c still refer to FC_TOG.
Is that intentional? Should they be changed to CK_TOGG?

@drashna
Copy link
Member Author

drashna commented Feb 9, 2021

I think that aliasing them may be a better option, for now, actually.

@drashna drashna merged commit 7161d65 into qmk:develop Feb 9, 2021
@drashna drashna deleted the remove/fauxclick branch February 9, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core documentation keyboard keymap translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drashna @spidey3 @tzarc @fauxpark