Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: add pin_defs for MK66F18 #12419

Merged
merged 1 commit into from Mar 30, 2021
Merged

core: add pin_defs for MK66F18 #12419

merged 1 commit into from Mar 30, 2021

Conversation

stapelberg
Copy link
Contributor

Description

This is in preparation for #10171

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@stapelberg stapelberg mentioned this pull request Mar 29, 2021
Merged
14 tasks
@github-actions github-actions bot added the core label Mar 29, 2021
zvecr
zvecr requested changes Mar 29, 2021
View reviewed changes
tmk_core/common/chibios/pin_defs.h Outdated Show resolved Hide resolved
@zvecr zvecr requested a review from a team March 29, 2021 15:42
@stapelberg
core: add pin_defs for MK66F18
9a13945 
This is in preparation for qmk#10171
@stapelberg stapelberg requested review from zvecr and removed request for a team March 29, 2021 15:54
@stapelberg
Copy link
Contributor Author

Looks like travis timed out: The job exceeded the maximum time limit for jobs, and has been terminated.

Could one of you restart it please?

@fauxpark
Copy link
Member

Restarting won't help.

@stapelberg
Copy link
Contributor Author

Restarting won't help.

Okay. I assume the Travis breakage is unrelated, though.

What’s the next step in getting this merged?

I think I accidentally removed the review request from qmk/collaborators as a side effect of re-requesting a review via the GitHub UI. Just want to make sure that doesn’t accidentally mess up the workflow.

@fauxpark fauxpark requested a review from a team March 30, 2021 09:57
@tzarc tzarc merged commit e95a4f4 into qmk:develop Mar 30, 2021
@tzarc
Copy link
Member

tzarc commented Mar 30, 2021

What’s the next step in getting this merged?

Not much!

@stapelberg stapelberg deleted the mk66f18 branch March 30, 2021 11:20
@drashna drashna mentioned this pull request May 22, 2021
Closed
14 tasks
mrtnee pushed a commit to mrtnee/qmk_firmware that referenced this pull request Nov 20, 2021
@stapelberg @mrtnee
core: add pin_defs for MK66F18 (qmk#12419)
28face5 
This is in preparation for qmk#10171
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@stapelberg @nhongooi
core: add pin_defs for MK66F18 (qmk#12419)
3b55972 
This is in preparation for qmk#10171
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stapelberg @fauxpark @tzarc @zvecr