Apply the "NO_LIMITED_CONTROLLER_CONNECT" fix to atmega16u2 too (and … #12482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed while browsing code, that this modifier macro is applied only to the atmega32u2 mcu,
however looking at LUFA code it is something that applies to all Series 2 and Xmega AVRs too.
Looking at LUFA code this macro is tested for in very few places, and looks like it is only tested
in the case of MCUs for which it matters, so it's okay for it to be indiscriminately defined.
So looking at what keyboards we have I found we have two atmega16u2 keyboards in our keyboards folder:
These keyboards are most likely benefited by this change.
Tested by @SidneyBovet
Types of Changes
Issues Fixed or Closed by This PR
Checklist
Tested by @SidneyBovet