Skip to content

fix #12673 #12674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2021
Merged

fix #12673 #12674

merged 2 commits into from
Jul 16, 2021

Conversation

jhanschoo
Copy link

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Failures when running make all don't seem to be related to my change. Note that I came across this bug while reading the source learning to implement a custom RGB matrix effect, so I might be mistaken and any input from maintainers more experienced is very welcome.

@github-actions github-actions bot added the core label Apr 24, 2021
@stale
Copy link

stale bot commented Jun 9, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label Jun 16, 2021
@drashna drashna requested a review from a team June 16, 2021 03:57
fauxpark
fauxpark requested changes Jun 16, 2021
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also be done for LED Matrix.

@drashna
Copy link
Member

drashna commented Jul 3, 2021

This has some merge conflicts that need resolving.

@jhanschoo jhanschoo force-pushed the fix-upstream-12673 branch from 3ad1d0e to e0e87e4 Compare July 7, 2021 05:20
@jhanschoo jhanschoo force-pushed the fix-upstream-12673 branch from e0e87e4 to d29eec8 Compare July 7, 2021 05:26
@jhanschoo
Copy link
Author

bump @drashna @fauxpark

@drashna
Copy link
Member

drashna commented Jul 16, 2021

Thanks!

@drashna drashna merged commit 10d7eca into qmk:develop Jul 16, 2021
@jhanschoo jhanschoo deleted the fix-upstream-12673 branch July 16, 2021 16:47
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@jhanschoo @nhongooi
Fix LED Hit Counter for LED/RGB Matrix (qmk#12674)
dabea86
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@jhanschoo
Fix LED Hit Counter for LED/RGB Matrix (qmk#12674)
514a9b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhanschoo @drashna @fauxpark