-
-
Notifications
You must be signed in to change notification settings - Fork 42.4k
Retain brightness with lighting layers #13025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain brightness with lighting layers #13025
Conversation
|
Thank you for your contribution! |
|
I‘d still like to get this merged. |
|
This should target develop, though. |
|
@drashna thanks for the review. changed target to |
Awesome! Though, it looks like you have a merge conflict here. And one that looks like you'll need to rebase/merge locally to fix. |
|
will provide an update after rebasing later today. sorry, went under my radar. |
Add guard `RGBLIGHT_LAYERS_RETAIN_VAL` to retain the currently used val when applying lighting layers.
c576c80 to
f1097df
Compare
|
done |
|
Thanks! |
Add guard `RGBLIGHT_LAYERS_RETAIN_VAL` to retain the currently used val when applying lighting layers.
Add guard `RGBLIGHT_LAYERS_RETAIN_VAL` to retain the currently used val when applying lighting layers.
Add guard
RGBLIGHT_LAYERS_RETAIN_VALto retain the currently used val (as returned byrgblight_get_val())when applying lighting layers.
Checklist