Skip to content

Retain brightness with lighting layers #13025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

pstadler
Copy link

@pstadler pstadler commented May 28, 2021

Add guard RGBLIGHT_LAYERS_RETAIN_VAL to retain the currently used val (as returned by rgblight_get_val())
when applying lighting layers.

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@stale
Copy link

stale bot commented Jul 16, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@pstadler
Copy link
Author

I‘d still like to get this merged.

@stale stale bot removed the awaiting changes label Jul 20, 2021
@drashna
Copy link
Member

drashna commented Jul 20, 2021

This should target develop, though.
You can edit the title, and that should allow you to retarget.

@pstadler pstadler changed the base branch from master to develop July 20, 2021 06:34
@pstadler
Copy link
Author

@drashna thanks for the review. changed target to develop.

@drashna drashna requested review from spidey3 and a team July 20, 2021 16:14
@drashna
Copy link
Member

drashna commented Jul 20, 2021

@drashna thanks for the review. changed target to develop.

Awesome! Though, it looks like you have a merge conflict here. And one that looks like you'll need to rebase/merge locally to fix.

@pstadler
Copy link
Author

will provide an update after rebasing later today. sorry, went under my radar.

Add guard `RGBLIGHT_LAYERS_RETAIN_VAL` to retain the currently used val
when applying lighting layers.
@pstadler pstadler force-pushed the rgblight-layers-retain-brightness branch from c576c80 to f1097df Compare July 20, 2021 20:16
@pstadler
Copy link
Author

done

@drashna
Copy link
Member

drashna commented Jul 22, 2021

Thanks!

@drashna drashna merged commit fb9a254 into qmk:develop Jul 22, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Add guard `RGBLIGHT_LAYERS_RETAIN_VAL` to retain the currently used val
when applying lighting layers.
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Add guard `RGBLIGHT_LAYERS_RETAIN_VAL` to retain the currently used val
when applying lighting layers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants