Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add oled_invert #13172

Merged
merged 3 commits into from Jun 18, 2021
Merged

Add oled_invert #13172

merged 3 commits into from Jun 18, 2021

Conversation

ignazkevenaar
Copy link

@ignazkevenaar ignazkevenaar commented Jun 10, 2021 •
edited

Description

This change adds the ability to invert displays to the standard OLED driver by sending the appropriate i2c command to a SSD1306 or SH1106 OLED.

Please tell me if my returns are sensible, and whether or not I should condense the if statements more.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

drashna
drashna requested changes Jun 16, 2021
View reviewed changes
drivers/oled/oled_driver.c Outdated Show resolved Hide resolved
drivers/oled/oled_driver.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team June 16, 2021 17:23
ignazkevenaar and others added 2 commits June 18, 2021 11:50
@ignazkevenaar @drashna
Update drivers/oled/oled_driver.c
cf457b5 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@ignazkevenaar @drashna
Update drivers/oled/oled_driver.c
36b1428 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@fauxpark
Copy link
Member

Thanks!

@fauxpark fauxpark merged commit 0311c80 into qmk:develop Jun 18, 2021
@fauxpark fauxpark mentioned this pull request Jun 18, 2021
Merged
14 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@ignazkevenaar @drashna @nhongooi
Add oled_invert (qmk#13172)
aae2325 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ignazkevenaar @fauxpark @drashna