Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize our jsonschema by using refs #13271

Merged
merged 6 commits into from
Jun 25, 2021
Merged

Optimize our jsonschema by using refs #13271

merged 6 commits into from
Jun 25, 2021

Conversation

skullydazed
Copy link
Member

Description

This should make working with our jsonschema easier in the long run.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team June 20, 2021 18:59
@github-actions github-actions bot added cli qmk cli command keyboard python labels Jun 20, 2021
@skullydazed skullydazed mentioned this pull request Jun 20, 2021
Closed
14 tasks
tzarc
tzarc approved these changes Jun 20, 2021
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weak approval. Saw that it's confirmed working for #13263.

@drashna drashna requested a review from a team June 21, 2021 16:24
@skullydazed skullydazed merged commit b908275 into develop Jun 25, 2021
@stapelberg stapelberg mentioned this pull request Jun 25, 2021
Closed
6 tasks
@fauxpark fauxpark deleted the optimise_jsonschemas branch August 3, 2021 10:17
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@skullydazed @nhongooi
Optimize our jsonschema by using refs (qmk#13271)
90daf00 
* fix some broken info.json files

* optimize our jsonschema using refs

* fix formatting after vscode broke it

* make flake8 happy

* cleanup

* make our schema validation more compact and flexible
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@skullydazed
Optimize our jsonschema by using refs (qmk#13271)
d932e3b 
* fix some broken info.json files

* optimize our jsonschema using refs

* fix formatting after vscode broke it

* make flake8 happy

* cleanup

* make our schema validation more compact and flexible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command keyboard python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skullydazed @tzarc @fauxpark