Skip to content

Convert Dip Switch callbacks to boolean functions #13399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2021
Merged

Convert Dip Switch callbacks to boolean functions #13399

merged 2 commits into from
Jul 1, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 1, 2021

Description

Like the title says. Changed the callbacks from void, to bool, so that kb level can be overridden.

Types of Changes

  • Core
  • Bugfix
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team July 1, 2021 06:18
@github-actions github-actions bot added core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support labels Jul 1, 2021
@tzarc tzarc requested a review from a team July 1, 2021 06:43
fauxpark
fauxpark reviewed Jul 1, 2021
View reviewed changes
fauxpark
fauxpark reviewed Jul 1, 2021
View reviewed changes
@drashna drashna merged commit 0bde920 into qmk:develop Jul 1, 2021
@drashna drashna deleted the core/dip_switches branch July 1, 2021 15:22
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @nhongooi
Convert Dip Switch callbacks to boolean functions (qmk#13399)
46b9028
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna
Convert Dip Switch callbacks to boolean functions (qmk#13399)
72f7cfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core documentation keyboard keymap translation via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drashna @tzarc @fauxpark