Skip to content

AW20216 use register increment for framebuffer flushes #13430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2021
Merged

AW20216 use register increment for framebuffer flushes #13430

merged 2 commits into from
Jul 3, 2021

Conversation

Gigahawk
Copy link

@Gigahawk Gigahawk commented Jul 3, 2021 •
edited
Loading

Description

This PR updates aw20216.c to take advantage of register address auto increment similar to some of the ISSI drivers.

This effectively obsoletes #13173, which contains a similar implementation.

I've done some testing using @KarlK90's debug trace prototype and this seems to be orders of magnitude faster than the existing code (pre and post update refers to before and after the commits in this PR):

data

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command core dependencies documentation keyboard keymap python translation via Adds via keymap and/or updates keyboard for via support labels Jul 3, 2021
@Gigahawk Gigahawk changed the base branch from master to develop July 3, 2021 12:21
@github-actions github-actions bot removed cli qmk cli command via Adds via keymap and/or updates keyboard for via support documentation dependencies keymap translation python keyboard labels Jul 3, 2021
@drashna drashna requested a review from a team July 3, 2021 14:34
@drashna drashna requested a review from a team July 3, 2021 14:35
@drashna drashna merged commit 6ac037a into qmk:develop Jul 3, 2021
@Gigahawk Gigahawk mentioned this pull request Jul 7, 2021
Closed
14 tasks
@alexmarmon alexmarmon mentioned this pull request Jul 10, 2021
Merged
14 tasks
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Gigahawk @nhongooi
AW20216 use register increment for framebuffer flushes (qmk#13430)
0788159
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@Gigahawk
AW20216 use register increment for framebuffer flushes (qmk#13430)
7d0926f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gigahawk @drashna @fauxpark