-
-
Notifications
You must be signed in to change notification settings - Fork 42.4k
[Keyboard] Fix up SplitKB keyboards #13511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm.
bf7cc58 to
1352c3a
Compare
|
A heads up, since this does alter your keymaps. |
e1a3d3f to
a5374be
Compare
| { KC_NO, KC_NO, R34, R35, R36, R37, R38, R39 }, \ | ||
| { R45, R46, R47, R48, R49, KC_NO, KC_NO, KC_NO }, \ | ||
| } | ||
| #define LAYOUT_split_3x6_5 LAYOUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reasoning behind this?
Defining LAYOUT_split_3x6_5 as LAYOUT breaks existing keymaps defined using LAYOUT_split_3x6_5 as four additional KC_NOs are required in the keymap.
If streamlining was the intention, would it not be better to remove LAYOUT_split_3x6_5 altogether?
Description
This does a number of things:
Types of Changes
Checklist