Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix_scan_x -> x_task #13748

Merged
merged 1 commit into from
Jul 28, 2021
Merged

matrix_scan_x -> x_task #13748

merged 1 commit into from
Jul 28, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 28, 2021 •
edited
Loading

Description

Cherry picked from the decoupling of matrix scan running part of the task loop.

(Hopefully this will target the next develop cycle)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team July 28, 2021 00:47
@drashna drashna requested a review from a team July 28, 2021 01:41
@drashna
Copy link
Member

drashna commented Jul 28, 2021

I like the change. It's ... much more accurate to what is going on.

@zvecr zvecr merged commit 03d258c into qmk:develop Jul 28, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
matrix_scan_x -> x_task (qmk#13748)
2a3a6bc
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
matrix_scan_x -> x_task (qmk#13748)
eae1603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @drashna @fauxpark