Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rgb matrix/enable modes explicitly #13758

Merged
merged 5 commits into from
Aug 17, 2021
Merged

Rgb matrix/enable modes explicitly #13758

merged 5 commits into from
Aug 17, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 28, 2021 •
edited
Loading

Description

Changes RGB Matrix to require explicit activation of modes, rather than explicit deactivation of modes. This way, new modes can be added without risk of bloat, etc.

To Do:

  • Adding legacy "enabling"
  • Add to LED Matrix

Types of Changes

  • Core
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

  • Feature creep

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna force-pushed the rgb_matrix/enable_modes_explicitly branch from e11b245 to bd5c2ff Compare July 28, 2021 15:04
@drashna drashna requested a review from a team July 28, 2021 20:09
@drashna drashna marked this pull request as ready for review July 28, 2021 20:09
@filterpaper filterpaper mentioned this pull request Jul 29, 2021
Merged
14 tasks
@fauxpark fauxpark requested a review from a team July 31, 2021 07:24
@filterpaper
Copy link
Contributor

@drashna Is rgb_matrix_legacy_enables.h meant to ease-in this change until the following breaking change cycle?

@drashna
Copy link
Member Author

drashna commented Jul 31, 2021 •
edited
Loading

@drashna Is rgb_matrix_legacy_enables.h meant to ease-in this change until the following breaking change cycle?

Yes. Exactly.

A small change now, just to get it over the line. And then cleanup, once there is more time.

@tzarc tzarc merged commit 7da97c2 into qmk:develop Aug 17, 2021
@drashna drashna deleted the rgb_matrix/enable_modes_explicitly branch August 17, 2021 19:25
@noroadsleft noroadsleft mentioned this pull request Aug 23, 2021
Merged
7 tasks
@blueyed blueyed mentioned this pull request Oct 29, 2021
Closed
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@drashna @nhongooi
Rgb matrix/enable modes explicitly (qmk#13758)
5dcbdfe 
* Change animations to require explicet activation

* Add support for legacy config

* Make default for now

* Add LED Matrix support

* change LED Matrix docs
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@drashna
Rgb matrix/enable modes explicitly (qmk#13758)
0e2f59b 
* Change animations to require explicet activation

* Add support for legacy config

* Make default for now

* Add LED Matrix support

* change LED Matrix docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@drashna @filterpaper @tzarc @fauxpark