Skip to content

Move chibios board files to allow tmk_core platform migration #13777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2021
Merged

Move chibios board files to allow tmk_core platform migration #13777

merged 2 commits into from
Aug 17, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 29, 2021 •
edited
Loading

Description

# move board files out the way
platforms/chibios/* -> platforms/chibios/boards/

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Jul 29, 2021
@zvecr
Copy link
Member Author

zvecr commented Jul 30, 2021 •
edited
Loading

Going to limit scope, and just move the board files in preparation for the other tmk -> platform changes.

@zvecr zvecr closed this Jul 30, 2021
@zvecr zvecr reopened this Aug 7, 2021
@zvecr zvecr force-pushed the feature/move_platform branch 2 times, most recently from 1a3659c to a8b2f15 Compare August 7, 2021 21:36
@zvecr zvecr changed the title Migrate tmk_core platforms Move chibios board files to allow tmk_core platform migration Aug 7, 2021
@zvecr zvecr requested a review from a team August 7, 2021 21:45
@zvecr zvecr marked this pull request as ready for review August 7, 2021 21:45
@zvecr zvecr mentioned this pull request Aug 7, 2021
Merged
14 tasks
@drashna
Copy link
Member

drashna commented Aug 8, 2021 •
edited
Loading

Heads up:

build_keyboard.mk:154: platforms/chibios/QMK_PROTON_C/convert_to_proton_c.mk: No such file or directory
gmake[1]: *** No rule to make target 'platforms/chibios/QMK_PROTON_C/convert_to_proton_c.mk'.  Stop.

Just needs the updated path.

Also, /tmk_core/chibios.mk, line 243 looks like it needs to be updated too.

@zvecr zvecr force-pushed the feature/move_platform branch from 76d6db8 to 01a9a28 Compare August 9, 2021 18:47
@zvecr zvecr force-pushed the feature/move_platform branch from 01a9a28 to 59f47dd Compare August 17, 2021 23:02
@zvecr zvecr merged commit 4c9003b into qmk:develop Aug 17, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
Move chibios board files to allow tmk_core platform migration (qmk#13777
dba0dd9 
)

* Move board files

* fix up after rebase
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Move chibios board files to allow tmk_core platform migration (qmk#13777
326a443 
)

* Move board files

* fix up after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zvecr @drashna @tzarc @fauxpark