Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store LED driver config in flash #13799

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Store LED driver config in flash #13799

merged 1 commit into from
Jul 31, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jul 30, 2021 •
edited
Loading

Description

Aligns all led drivers after #13480. However instead of using PROGMEM, it uses __flash to avoid having to change the implementations.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team July 30, 2021 22:02
@drashna
Copy link
Member

drashna commented Jul 31, 2021

Seems to work fine on both AVR and ARM controllers 👍🏻

@zvecr zvecr force-pushed the feature/PROGMEM_led_drivers branch from 2d93d1b to a953983 Compare July 31, 2021 13:33
@zvecr zvecr merged commit 70fb3e1 into qmk:develop Jul 31, 2021
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@zvecr @nhongooi
__flash? (qmk#13799)
e1ab183
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
__flash? (qmk#13799)
c8d6524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core documentation keyboard translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @drashna @fauxpark