Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
qmk doctoris a bit too strict on a couple of issues, which can lead to false-positive warnings:To determine if the
qmk_firmwarehome is a git repository, thedoctorchecks, if${QMK_FIRMWARE}/.gitis a directory. However, ifqmk_firmwareis a git submodule, then.gitwill be a file instead of a directory. This PR relaxes the requirement, allowing.gitto be a file.When checking for the installed
udevrules, thedoctorsearches only in/etc/udev/rules.d/*.rules. According toman udev, this isn't the only directory, whereudevrules can be located:In particular, the official
arch/manjaroqmkpackage places the udev rules into/usr/lib/udev/rules.d/50-qmk.rules, leading to a false positive. This PR makes thedoctoralso search forudevrules in/usr/lib/udev/rules.d/,/usr/local/lib/udev/rules.d/and/run/udev/rules.d/.Types of Changes
Checklist