Fix combo_disable
#13988
Merged
Fix combo_disable
#13988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dump key buffer when combos are disabled. - Recursive calls to `dump_key_buffer` need to start dumping the buffer from index i+1 to avoid possible infinite loops. - Handle combo key releases even though combo processing is disabled.
13 tasks
fauxpark
approved these changes
Aug 13, 2021
drashna
approved these changes
Aug 13, 2021
|
@tzarc Since this is a bug fix, I'd feel better if this made it in on this cycle, rather than q3's. Thoughts? |
|
I can confirm that this fixes the issue I described here: #8591 (comment). Thanks @sevanteri! |
This is the q3 cycle :) |
tzarc
approved these changes
Aug 14, 2021
|
Can also confirm that this fixes the issue described. |
nhongooi
pushed a commit
to nhongooi/qmk_firmware
that referenced
this pull request
Dec 5, 2021
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a couple of issues with
combo_disablefunction calls.The key buffer was not emptied when disabling combos; I had removed the
dump_key_buffer()call as it could lead to infinite loops. Removing the call it seems wasn't the right move.Now recursive calls to
dump_key_bufferstart from the next key instead of the key that is "currently being dumped" from the buffer.Another issues with disabling combos was that any currently active combo wasn't released on key releases.
Now combo key releases are always handled, even if combo processing is disabled.
Easy way to test the current issues:
LT(_LAYER, KC_X)_LAYER, calldisable_combo()Then just hold the combo for a while to activate the layer. On release the layer stays on.
I've messaged the two I know had issues with this to review this.
Types of Changes
Checklist