Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another GMMK Pro ANSI Keymap with custom RGB. #14243

Merged
merged 3 commits into from Jan 11, 2022

Conversation

cedrikl
Copy link

@cedrikl cedrikl commented Aug 30, 2021

Add a GMMK Pro simple keymap with RGB support.

Description

Add a GMMK Pro Keymap + Userspace that supports:

  • A basic 2 layer(1 + momentary keys)
  • RGB support
  • Keyboard brightness (RGB value) control

code in rgb_matrix_map.h is a little unorthodox but is a visual representation of the matrix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team August 31, 2021 22:31
@stale
Copy link

stale bot commented Oct 24, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

users/cedrikl/cedrikl.c Outdated Show resolved Hide resolved
keyboards/gmmk/pro/ansi/keymaps/cedrikl/keymap.c Outdated Show resolved Hide resolved
keyboards/gmmk/pro/ansi/keymaps/cedrikl/keymap.c Outdated Show resolved Hide resolved
Cedrik Lussier added 2 commits October 25, 2021 15:23
Moved backlight controll to FN+(A,S,D) to allow RWin (FN+LWIN) + Arrows
for windows window management within kvm over IP when running linux +
    i3.
@drashna drashna requested a review from a team October 27, 2021 00:00
@cedrikl cedrikl requested review from fauxpark and removed request for a team November 22, 2021 14:24
@stale
Copy link

stale bot commented Jan 9, 2022

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@cedrikl
Copy link
Author

cedrikl commented Jan 9, 2022

@fauxpark would you be able to validate the requested changes I have completed? Thank you.

@drashna drashna requested a review from a team January 9, 2022 02:15
@stale stale bot removed the awaiting changes label Jan 9, 2022
@drashna drashna merged commit c205223 into qmk:develop Jan 11, 2022
@drashna
Copy link
Member

drashna commented Jan 11, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants