Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change keyboard level include guards to pragma once #14248

Merged
merged 3 commits into from Sep 1, 2021
Merged

Change keyboard level include guards to pragma once #14248

merged 3 commits into from Sep 1, 2021

Conversation

fauxpark
Copy link
Member

Description

And clean up a lot of layout macros.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark
Change keyboard level include guards to pragma once
0efa81c 
And clean up a lot of layout macros
@fauxpark fauxpark requested a review from a team August 31, 2021 05:07
@fauxpark
Copy link
Member Author

Lint errors are all non-assignment stuff from rules.mk.

noroadsleft
noroadsleft requested changes Aug 31, 2021
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • keyboards/bigseries/3key/config.h: Lines 58-59 should be deleted.

@tzarc tzarc merged commit 41c50bb into qmk:develop Sep 1, 2021
@fauxpark fauxpark deleted the pragma-once-layout-macros branch September 1, 2021 09:08
@fauxpark fauxpark mentioned this pull request Sep 1, 2021
Merged
14 tasks
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@fauxpark @ptrxyz
Change keyboard level include guards to pragma once (qmk#14248)
9f09ed6 
* Change keyboard level include guards to `pragma once`

And clean up a lot of layout macros

* Oops

* Remove dangling endif
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 3, 2022
@fauxpark @coquizen
Change keyboard level include guards to pragma once (qmk#14248)
62868e6 
* Change keyboard level include guards to `pragma once`

And clean up a lot of layout macros

* Oops

* Remove dangling endif
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fauxpark @drashna @tzarc @noroadsleft