-
-
Notifications
You must be signed in to change notification settings - Fork 42.4k
Rework and expand Pointing Device support #14343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1abbffc to
9ebbf9b
Compare
2f34a29 to
67ed15f
Compare
84fa543 to
9076e6a
Compare
|
@daskygit added timeout check for debug printing, so it shouldn't be too bad now. And preprocessor statements to remove the code, if console isn't enabled. |
5f04eea to
b1b7538
Compare
|
@atulloh wanted to update the oddball to include the changes here. If you wouldn't mind confirming they don't break anything? I don't have a working adns9800 sensor ATM, so I can't verify, but the pmw3360 sensor does appear to work properly. |
@drashna Sure, I'll dig out that boards over the weekend and see if it's all good. Nice to see all this consolidated 👍 |
Awesome! And yeah, more boards are getting sensors, so it's been on my mind for a while now. Wanted to make it dead easy to add support for people, since otherwise it will be a lot of copy-paste that gets fragmented, etc. |
b4b22b5 to
0c99eea
Compare
0c99eea to
73cd3fd
Compare
|
@atulloh Have you had a chance to test this out? |
Thanks to sillyworld on discord for letting me know it wasn't working
Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com>
88edb46 to
d05869d
Compare
Description
Give pointing device support some much needed love.
This adds a "driver" value for pointing device feature, so you can quickly and simply add support for a sensor to act as pointing device by specifying the sensor type.
Additionally, it adds more robust user callbacks to help with these changes.
It also generalizes the sensor code, so that they don't have pointing device specific code, and can be used for other purposes (such as with HID joystick).
Types of Changes
Checklist