Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Arduino-style analogRead() #14348

Merged
merged 1 commit into from Sep 8, 2021
Merged

Remove Arduino-style analogRead() #14348

merged 1 commit into from Sep 8, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Sep 8, 2021

Description

This was deprecated a few cycles ago, in favour of analogReadPin() which takes a QMK-style pin. There are no more usages in the repo.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team September 8, 2021 12:07
@zvecr zvecr merged commit d977e5d into qmk:develop Sep 8, 2021
@fauxpark fauxpark deleted the remove-arduino-analogread branch September 8, 2021 22:41
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@fauxpark @ptrxyz
Remove Arduino-style analogRead() (qmk#14348)
15f6497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fauxpark @zvecr