Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GCC version check from song list inclusion #14600

Merged
merged 1 commit into from Sep 25, 2021
Merged

Remove GCC version check from song list inclusion #14600

merged 1 commit into from Sep 25, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Sep 25, 2021

Description

This appears to not be an issue with avr-gcc 5. May have been fixed with the binaries, not sure.

But appears to be safe to remove.

Types of Changes

  • Core
  • Enhancement/optimization

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team September 25, 2021 16:34
@github-actions github-actions bot added the core label Sep 25, 2021
@zvecr zvecr merged commit e1bf49f into qmk:develop Sep 25, 2021
@drashna drashna deleted the audio/song_list branch September 25, 2021 17:57
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Sep 27, 2021
Merge remote-tracking branch 'qmk/develop' into develop
4a51198 
* qmk/develop: (44 commits)
  Zinc: Clean up LTO rules (qmk#14597)
  SquishyTKL: Layouts cleanup (qmk#14594)
  Cleanup issues identified by lgtm (qmk#14459)
  Adding SP Mini keymap. (qmk#14593)
  [Keyboard] Fix Compile issues for Signum 3.0 (qmk#14588)
  [Keyboard] Fix double comment in config files (qmk#14615)
  Unicomp Mini M handwired Configurator fix (qmk#14609)
  Remove unused `IS_COMMAND()` instances and Magic Key definitions (qmk#14610)
  Remove references to KBFirmware JSON Parser (qmk#14608)
  GG Keyboards Genesis: Layout Macro update and clean-up (qmk#14606)
  Exclusive E6 RGB Refactor (qmk#14604)
  FLX Virgo: metadata clean-up (qmk#14605)
  Saka68 Solder Refactor (qmk#14596)
  Saka68 Hotswap Refactor (qmk#14595)
  Remove GCC version check from song list inclusion (qmk#14600)
  [Keyboard] add keyboard dyz_TKL (qmk#14535)
  [Keyboard] add keyboard dyz40 (qmk#14533)
  [Keyboard] add keyboard selka40 (qmk#14560)
  [Keyboard] Fix pin spacing alignmnent (qmk#14592)
  Remove keyboard-level `COMBO_ENABLE` rules (qmk#14550)
  ...
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@drashna @ptrxyz
Remove GCC version check from song list inclusion (qmk#14600)
6382543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drashna @zvecr