Skip to content

Correct the Turkish F '?' keycode (TR_QUES) #14740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2021
Merged

Correct the Turkish F '?' keycode (TR_QUES) #14740

merged 1 commit into from
Oct 7, 2021
+1 −1

Conversation

precondition
Copy link
Contributor

@precondition precondition commented Oct 7, 2021 •
edited by zvecr
Loading

Description

This is a tiny change:
#define TR_QUES S(TR_ASTR) // ? → #define TR_QUES S(TR_SLSH) // ?

See the second right-most key of the numrow:
turkish F layout

I also checked sendstring_turkish_f.h but that file doesn't have the same mistake.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@precondition
Correct the Turkish F '?' keycode (TR_QUES)
8a3b99c 
define TR_QUES S(TR_ASTR) // ? → define TR_QUES S(TR_SLSH) // ?
@github-actions github-actions bot added the core label Oct 7, 2021
@fauxpark fauxpark requested a review from a team October 7, 2021 08:51
@zvecr zvecr merged commit 0d72438 into qmk:develop Oct 7, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@precondition @ptrxyz
Correct the Turkish F '?' keycode (TR_QUES) (qmk#14740)
3c43ce4 
define TR_QUES S(TR_ASTR) // ? → define TR_QUES S(TR_SLSH) // ?
@precondition precondition deleted the turkish_f_ques branch October 5, 2022 07:56
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@precondition
Correct the Turkish F '?' keycode (TR_QUES) (qmk#14740)
f43826c 
define TR_QUES S(TR_ASTR) // ? → define TR_QUES S(TR_SLSH) // ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@precondition @fauxpark @zvecr