Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Adafruit BLE configuration defines #14749

Merged
merged 2 commits into from Oct 8, 2021

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 8, 2021

Description

By convention these defines should be in SCREAMING_SNAKE_CASE.

The frequency define has been changed to ADAFRUIT_BLE_SCK_DIVISOR as there is no F_CPU equivalent for ARM, so it cannot be easily calculated automatically. It defaults to 2, the value it would be for a Feather 32U4 running at 8MHz with a 4MHz SPI clock speed. ARM users will likely always need to increase this as those chips run at much higher speeds, and even with the /2 division, the BLE module probably won't be able to keep up.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@Duckle29 Duckle29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zvecr zvecr merged commit db41a34 into qmk:develop Oct 8, 2021
@fauxpark fauxpark deleted the adafruit-ble-defines branch October 8, 2021 20:50
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
* Improve Adafruit BLE configuration defines

* Formatting
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 3, 2022
* Improve Adafruit BLE configuration defines

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants