Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial USB2422 driver #14835

Merged
merged 12 commits into from Oct 21, 2021
Merged

Initial USB2422 driver #14835

merged 12 commits into from Oct 21, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 15, 2021 •
edited

Description

Initial migration of USB2422 logic out from arm_atsam protocol code.

Includes i2c_master bodges, as longer term this will be implemented by the riot port.

  • Double check MD fork for any required changes
  • Handle Address of bootloader's serial number if available logic in platform agnostic way
    • MD logic results in an empty string on the boards tested, so no real rush to implement this just yet
  • Expose additional config options?
    • Might be implemented as another iteration when used by more than just the CTRL/ALT?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the title Feature/usb2422 USB2422 driver Oct 15, 2021
@zvecr zvecr marked this pull request as ready for review October 15, 2021 23:01
@zvecr zvecr requested a review from a team October 15, 2021 23:01
@zvecr zvecr changed the title USB2422 driver Initial USB2422 driver Oct 15, 2021
@drashna drashna requested a review from a team October 15, 2021 23:11
@zvecr zvecr merged commit 0093d3d into qmk:develop Oct 21, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Oct 22, 2021
Merge remote-tracking branch 'qmk/develop' into develop
2c85296 
* qmk/develop:
  Fix right half of Nyquist in 4x12 mode having row shifted up by one (qmk#14914)
  Pteron36 Refactor (qmk#14904)
  Initial USB2422 driver (qmk#14835)
  Split out arm_atsam shift register logic (qmk#14848)
  Fix ccache default (qmk#14906)
  Move USE_CCACHE logic to common location (qmk#14899)
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Initial USB2422 driver (qmk#14835)
35e5349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @drashna