Skip to content

Split out HAPTIC_ENABLE to have separate DRIVER option #14854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2021
Merged

Split out HAPTIC_ENABLE to have separate DRIVER option #14854

merged 3 commits into from
Oct 18, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 17, 2021 •
edited
Loading

Description

Align with recent implementation patterns, allowing the cli workaround to be removed.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the awaiting_pr Relies on another PR to be merged first label Oct 17, 2021
@drashna drashna requested review from drashna and a team October 17, 2021 20:30
@zvecr zvecr force-pushed the feature/haptic_enable_driver branch from b4bacdb to 4896dd6 Compare October 17, 2021 21:42
@zvecr zvecr removed the awaiting_pr Relies on another PR to be merged first label Oct 17, 2021
@zvecr zvecr marked this pull request as ready for review October 17, 2021 21:47
fauxpark
fauxpark requested changes Oct 17, 2021
View reviewed changes
@zvecr @fauxpark
Update generic_features.mk
ce2d40a 
Co-authored-by: Ryan <fauxpark@gmail.com>
zvecr
zvecr commented Oct 17, 2021
View reviewed changes
@zvecr zvecr requested review from fauxpark and a team October 17, 2021 22:27
@drashna
Copy link
Member

drashna commented Oct 18, 2021

And can confirm that it doesn't break haptics

@zvecr zvecr merged commit 01b702b into qmk:develop Oct 18, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @fauxpark @ptrxyz
Split out HAPTIC_ENABLE to have separate DRIVER option (qmk#14854)
38cbf03 
* DRIVER -> ENABLE

* Update generic_features.mk

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update common_features.mk

Co-authored-by: Ryan <fauxpark@gmail.com>
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr @fauxpark
Split out HAPTIC_ENABLE to have separate DRIVER option (qmk#14854)
14db496 
* DRIVER -> ENABLE

* Update generic_features.mk

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update common_features.mk

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
cli qmk cli command core documentation keyboard keymap python translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark