Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename platform SRC variable #14894

Merged
merged 1 commit into from Oct 20, 2021
Merged

Rename platform SRC variable #14894

merged 1 commit into from Oct 20, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 20, 2021 •
edited

Description

Reusing the CHIBISRC logic for other platforms, but having the terminology still be linked to ChibiOS seems wrong.

Also removed the unused GFX variables.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team October 20, 2021 18:35
@github-actions github-actions bot added the core label Oct 20, 2021
@drashna drashna requested a review from a team October 20, 2021 19:07
@zvecr zvecr merged commit 5500c42 into qmk:develop Oct 20, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Oct 21, 2021
Merge remote-tracking branch 'qmk/develop' into develop
2193c67 
* qmk/develop:
  Tidy up LCD_ENABLE/visualizer references (qmk#14855)
  Relocate PS2 code (qmk#14895)
  Rename platform SRC variable (qmk#14894)
  Align PS/2 GPIO defines (qmk#14745)
  Fix type of Tap Dance max index variable (qmk#14887)
  Make the MAGIC_TOGGLE_GUI keycode work (qmk#14886)
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Rename platform SRC variable (qmk#14894)
314029c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @drashna @tzarc