Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocate PS2 code #14895

Merged
merged 3 commits into from Oct 20, 2021
Merged

Relocate PS2 code #14895

merged 3 commits into from Oct 20, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 20, 2021 •
edited

Description

More steps to getting rid of tmk_core.

This pass focuses on getting the files in a better location (and more importantly, out of tmk_core).

Future:

  • Refactor to PS2_DRIVER logic

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 20, 2021
@zvecr zvecr requested a review from a team October 20, 2021 19:53
@zvecr zvecr changed the title Relocate ps2 protocol code Relocate PS2 code Oct 20, 2021
@zvecr zvecr merged commit d4be4b6 into qmk:develop Oct 20, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Oct 21, 2021
Merge remote-tracking branch 'qmk/develop' into develop
2193c67 
* qmk/develop:
  Tidy up LCD_ENABLE/visualizer references (qmk#14855)
  Relocate PS2 code (qmk#14895)
  Rename platform SRC variable (qmk#14894)
  Align PS/2 GPIO defines (qmk#14745)
  Fix type of Tap Dance max index variable (qmk#14887)
  Make the MAGIC_TOGGLE_GUI keycode work (qmk#14886)
idank added a commit to idank/qmk_firmware that referenced this pull request Feb 11, 2022
@idank
ps2/avr: use the correct file name
0ec652e 
This was missed in qmk#14895.

Thanks to fauxpark for spotting this.
@idank idank mentioned this pull request Feb 11, 2022
Merged
11 tasks
tzarc pushed a commit that referenced this pull request Feb 11, 2022
@idank
ps2/avr: use the correct file name (#16316)
793f54f 
This was missed in #14895.

Thanks to fauxpark for spotting this.
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Relocate PS2 code (qmk#14895)
91ae0a4 
* Relocate ps2 protocol code

* clang

* Move makefile logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @tzarc