Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate makefile utilities to sub-directory #14917

Merged
merged 1 commit into from Oct 28, 2021
Merged

Migrate makefile utilities to sub-directory #14917

merged 1 commit into from Oct 28, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 22, 2021 •
edited

Description

First pass, some .mk files that dont really care about paths.

Folder name is up for grabs, could reuse util?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 22, 2021
@zvecr zvecr requested a review from a team October 22, 2021 21:16
drashna
drashna approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from merge conflict, it looks good.

@zvecr zvecr merged commit b780c79 into qmk:develop Oct 28, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Migrate makefile utilities to sub-directory (qmk#14917)
970eac6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @drashna @tzarc