Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align usbasp flashing behaviour #14928

Merged
merged 1 commit into from Oct 24, 2021
Merged

Align usbasp flashing behaviour #14928

merged 1 commit into from Oct 24, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 23, 2021

Description

Add detect loop per other flashers.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team October 23, 2021 19:39
@github-actions github-actions bot added the core label Oct 23, 2021
@drashna drashna requested a review from a team October 23, 2021 21:55
@zvecr zvecr merged commit 19b9e40 into qmk:develop Oct 24, 2021
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Oct 27, 2021
Merge remote-tracking branch 'qmk/develop' into develop
5176851 
* qmk/develop:
  [Keyboard] temporary fix for SpiderIsland 78 (qmk#14935) (qmk#14941)
  Fix Typo in documentation (qmk#14942)
  Begin to carve out platform/protocol API - Migrate keyboard_* calls (qmk#14888)
  Tidy up ADNS9800 and PMW3360 firmware blobs (qmk#14936)
  Align usbasp flashing behaviour (qmk#14928)
  [Keymap] Add logo to riblee userspace (qmk#14875)
  [Docs] Add default case to tap dance example 5. (qmk#14893)
  [Keymap] Add Gergoplex keymap (qmk#14768)
  [Keymap] Simplify unicode input mode change and CTRL and GUI swapping (qmk#14874)
  Reformat iris keymap antonlindstrom to be a bit more readable and consistent (qmk#14902)
  [Keymap] Jonavin userspace keymap updates INVERT_NUMLOCK_INDICATOR  (qmk#14880)
  Corrected keyboard layout which was causing issue in QMK configurator (qmk#14891)
  [Keyboard] Update encoder callback on Evolv75 (qmk#14757)
  [Keyboard] Add MW75 support (qmk#14833)
  Remove legacy handling for ErgoDox Infinity handedness (qmk#14919)
  Check usb transmit status in send_extra() (qmk#14643)
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Align usbasp flashing behaviour (qmk#14928)
75235d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @drashna @fauxpark