Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LTO logic from common.mk #14973

Merged
merged 1 commit into from Oct 28, 2021
Merged

Move LTO logic from common.mk #14973

merged 1 commit into from Oct 28, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 28, 2021 •
edited

Description

#13918 plans to remove/replace tmk_core/common.mk, so this PR moves the LTO logic to a "better" location (as well as removing the legacy warning).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team October 28, 2021 16:46
@zvecr zvecr merged commit 0c87e2e into qmk:develop Oct 28, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Move LTO logic from common.mk (qmk#14973)
5721ac2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core keyboard keymap optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @drashna