Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix develop after recent changes #14975

Merged
merged 2 commits into from Oct 28, 2021
Merged

Fix develop after recent changes #14975

merged 2 commits into from Oct 28, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 28, 2021 •
edited

Description

  • Fix sleep led compilation issues
  • Fix test compilation

Oops...

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Oct 28, 2021
@zvecr zvecr requested a review from a team October 28, 2021 21:51
@github-actions github-actions bot added the core label Oct 28, 2021
@zvecr zvecr changed the title Fix sleep led compilation issues Fix develop after recent changes Oct 28, 2021
@zvecr zvecr requested review from drashna and a team October 28, 2021 22:17
drashna
drashna approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@drashna drashna left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles properly 🎉

@zvecr zvecr merged commit 0f92614 into qmk:develop Oct 28, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
@zvecr @ptrxyz
Fix develop after recent changes (qmk#14975)
9de37e7 
* Fix sleep led issues

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @drashna