Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to persist MD LED framework settings #14980

Merged
merged 4 commits into from Nov 1, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 29, 2021

Description

This gets the ALT/CTRL feature compatible with the massdrop/qmk_firmware fork.

Future iterations will move away from the bespoke LED framework and to core RGB Matrix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the awaiting_pr Relies on another PR to be merged first label Oct 29, 2021
@zvecr zvecr marked this pull request as ready for review October 30, 2021 14:14
@zvecr zvecr removed the awaiting_pr Relies on another PR to be merged first label Oct 30, 2021
@zvecr zvecr requested a review from a team November 1, 2021 22:37
@tzarc tzarc merged commit 7ae0f37 into qmk:develop Nov 1, 2021
ptrxyz pushed a commit to ptrxyz/qmk_firmware that referenced this pull request Apr 9, 2022
* Add support to persist MD LED framework settings

* avoid out-of-bounds errors when SmartEEPROM is not enabled

* Update brightness defaults

* clang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants