Skip to content

[Docs] Squeezing space out of AVR #15243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 22, 2021
Merged

[Docs] Squeezing space out of AVR #15243

merged 9 commits into from
Nov 22, 2021

Conversation

drashna
Copy link
Member

@drashna drashna commented Nov 20, 2021

Description

Since it comes up often enough...

Types of Changes

  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested review from tzarc and a team November 20, 2021 23:37
tzarc
tzarc requested changes Nov 20, 2021
View reviewed changes
drashna and others added 2 commits November 20, 2021 15:54
@drashna @tzarc
Apply suggestions from code review
b388031 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@drashna
Add oled section
657605e
@drashna drashna requested review from tzarc and a team November 21, 2021 06:03
tzarc
tzarc requested changes Nov 22, 2021
View reviewed changes
drashna and others added 2 commits November 22, 2021 08:17
@tzarc tzarc changed the base branch from master to develop November 22, 2021 16:59
@drashna drashna requested a review from a team November 22, 2021 17:07
tzarc
tzarc requested changes Nov 22, 2021
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just calling out the old code, in case people decide to just copypaste whatever is in the doco.

@tzarc tzarc requested a review from a team November 22, 2021 17:08
@drashna @tzarc
oled clarifications
5abcd99 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc tzarc requested a review from a team November 22, 2021 17:11
@tzarc tzarc merged commit f4966a1 into qmk:develop Nov 22, 2021
@drashna drashna deleted the die_avr branch November 23, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drashna @tzarc