Skip to content

Remove use of __flash due to LTO issues #15268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2021
Merged

Remove use of __flash due to LTO issues #15268

merged 1 commit into from
Nov 24, 2021
+131 −117

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 22, 2021 •
edited
Loading

Description

Due the interaction of __flash and LTO, it seems like the short term solution is to move to PROGMEM till the issue resolves.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Nov 22, 2021
@zvecr zvecr requested a review from a team November 22, 2021 23:31
@drashna drashna requested review from tzarc and a team November 24, 2021 05:34
@tzarc tzarc merged commit 282e916 into qmk:develop Nov 24, 2021
peepeetee added a commit to peepeetee/qmk_firmware that referenced this pull request Dec 11, 2021
@peepeetee
apply qmk#15268
cea0d9a
peepeetee added a commit to peepeetee/qmk_firmware that referenced this pull request Dec 11, 2021
@peepeetee
apply qmk#15268
d80d096
@peepeetee peepeetee mentioned this pull request Dec 11, 2021
Merged
14 tasks
peepeetee added a commit to peepeetee/qmk_firmware that referenced this pull request Dec 11, 2021
@peepeetee
apply qmk#15268
331b439
ymlmkb pushed a commit to ymlmkb/qmk_firmware that referenced this pull request Jan 16, 2022
@peepeetee @csmyth-brinqa
apply qmk#15268
9c6926e
@silvinor silvinor mentioned this pull request Jan 23, 2022
Closed
14 tasks
peepeetee added a commit to peepeetee/qmk_firmware that referenced this pull request Jun 26, 2022
@peepeetee
apply qmk#15268
6632517
peepeetee added a commit to peepeetee/qmk_firmware that referenced this pull request Mar 15, 2023
@peepeetee
apply qmk#15268
7bcf119
@zvecr zvecr mentioned this pull request Jun 22, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug core documentation keyboard keymap translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @tzarc