Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added external spi flash driver. #15419

Merged
merged 38 commits into from Feb 11, 2022
Merged

Conversation

itarze
Copy link
Contributor

@itarze itarze commented Dec 7, 2021

Added external spi flash driver.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Dec 7, 2021
@tzarc tzarc added the needs doc label Dec 7, 2021
@itarze
Copy link
Contributor Author

itarze commented Dec 7, 2021

@tzarc Describe where the document should be added?

@drashna
Copy link
Member

drashna commented Dec 7, 2021

@tzarc
Copy link
Member

tzarc commented Dec 7, 2021

Almost, will need a flash_driver.md with descriptions of configurable items, as well as a link to the new page in the sidebar.

@drashna
Copy link
Member

drashna commented Dec 7, 2021

Almost, will need a flash_driver.md with descriptions of configurable items, as well as a link to the new page in the sidebar.

I should read more. But should be set up somewhat similarly, I think. At least in the sidebar for the docs, and such.

@tzarc tzarc self-assigned this Dec 7, 2021
@drashna drashna requested a review from a team December 18, 2021 02:58
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, all the "Kbyte" values have been converted to "byte", please confirm with hardware.

docs/ja/_summary.md Outdated Show resolved Hide resolved
docs/zh-cn/_summary.md Outdated Show resolved Hide resolved
drivers/flash/flash_spi.h Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.h Outdated Show resolved Hide resolved
drivers/flash/flash_spi.h Outdated Show resolved Hide resolved
drivers/flash/flash_spi.h Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
@tzarc
Copy link
Member

tzarc commented Feb 8, 2022

Please also confirm that usages of uintptr_t have been changed to uint32_t.

Joy Lee and others added 9 commits February 9, 2022 09:06
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Joy Lee and others added 13 commits February 9, 2022 09:30
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
@itarze itarze requested a review from tzarc February 9, 2022 02:29
common_features.mk Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
drivers/flash/flash_spi.c Outdated Show resolved Hide resolved
Joy Lee and others added 7 commits February 9, 2022 10:40
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
Co-authored-by: Nick Brassel <nick@tzarc.org>
@zvecr zvecr merged commit 71c0b97 into qmk:develop Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants