Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight tidy up of keyboard task loop #15725

Merged
merged 3 commits into from Jan 9, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 3, 2022

Description

Cherry picked from 15722 to hopefully minimise changes.

Main aim is to reduce the size of keyboard_task, as its become fairly bloated by the matrix scanning logic. Functionality should hopefully be identical after the changes.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team January 3, 2022 21:51
@zvecr zvecr changed the base branch from master to develop January 3, 2022 21:51
@github-actions github-actions bot added the core label Jan 3, 2022
@KarlK90
Copy link
Member

KarlK90 commented Jan 4, 2022

This looks good! Do you mind joining the forces with #15292 especially commit 314b067f0de8a4abd3b1d7de20049672d88d0643 which targets the same code region and goals? Maybe cherry picking or rebasing on top of that?

@zvecr
Copy link
Member Author

zvecr commented Jan 5, 2022

Would rather not couple this minor change to others, given its aim is to minimise diffs of future works.

I guess the crossover is more with #15722, as both intend to modify behaviour.

Copy link
Member

@daskygit daskygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested on a couple of boards too.

@KarlK90
Copy link
Member

KarlK90 commented Jan 7, 2022

Would rather not couple this minor change to others, given its aim is to minimise diffs of future works.

I guess the crossover is more with #15722, as both intend to modify behaviour.

Fair enough! I also had eyes on that one but as it was still in draft I decided that it would make more sense to post it here. Hmmn, what do you think about my proposal to do it for #15722 ?

@daskygit daskygit merged commit 7562f66 into qmk:develop Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants